Skip to main content

Weekly Engineering June 2019

Before: https://www.getoutline.com/doc/weekly-engineering-may-2019-xpC3p1qANa

Jun 27 - Almost Luau time!!!​

FLOWr POWr

Puru Dahal : When heroku’s (dyno) error rate spike way up all of a certain, check to see if dynos restarted - currently in monitor but plan to move to statusofallthings.

Praneeta Mhatre:

  1. keep all abs in one place ie in @globals[“ACTIVE_AB_TESTS”] ?
  2. how to push to staging - rules
    1. create staging from master first thing the morning - US office and Kazach office
    2. git merge into staging
  3. qa cases confirmation on tickets if there is no testing sheet
  4. new time for weekly eng meeting for more than half of eng team does not have to be up late in the night
  5. deploy process -ie when is ci skip ok, how to handle deploys before going offline. etc

Kelsey Raczak: designers testing

Follow-ups:

  1. any reason why liveramp tracking in EU would be down May 1? - praneeta- javscript_params - praneeta has a ticket to look into before end of sprint

Fires: Sparkpost blocked us - phishing email, plans to fix?

 Show and tell: none.

how do we feel this week collisions Sharing test servers wario rooms public channels qa testing all things nice

Jun 20 - AIGUUUUUULLLLLLL IS HERE!!!​

Puru Dahal :

Rails 5 makes belongs_to association required by default https://blog.bigbinary.com/2016/02/15/rails-5-makes-belong-to-association-required-by-default.html

Kelsey Raczak: designers testing

Praneeta Mhatre: cache policy on new images

Follow-ups:

  1. any reason why liveramp tracking in EU would be down May 1? - praneeta- javscript_params - did not look into it yet.

Fires: none.

 Show and tell: none.

how do we feel this week collisions Sharing test servers wario rooms public channels qa testing all things nice

Jun 13 - Bye Bye Skype​

Praneeta Mhatre:

  1. MR conversations and the benefits for maintaining a history

(ie don’t delete comments if not relevant, they are always relevant even when not - it shows that this edge case was considered and is either handled or doesn’t need to be ) 2. Avoid take if you can, please 3. balance of DRY vs AB Clean up ease

Ben Ross:

  1. any reason why liveramp tracking in EU would be down May 1? - praneeta- javscript_params

  2. don’t drop tables when it makes a rollback impossible

Joe Curlee: Naming convention of branches, how to link MRs in Airtable

Anuarbek Zakiryanov:

  1. please don't give the same namespaces for powrDrilldown and it's inner component

 Follow-ups: Quass for reviews - done Staging deploy speed - https://powrtrak.atlassian.net/browse/PM-6732 - asset cache ticket https://powrtrak.atlassian.net/browse/PM-6733 - common css files.

Fires: drop table, could not rollback. Cause of issue still unknown Theory - could not connect to db, but db connections are not full.

 Show and tell: none.

how do we feel this week collisions Sharing test servers wario rooms public channels qa testing all things nice

Jun 6 - Major technology fail​

Sergey Tyan:

  1. using const instead of let whenever possible

https://evertpot.com/javascript-let-const/ evertpot.com Use 'let' and 'const' instead of 'var' 2. proposal: create an airtable for code reviews - Teddy will update QuASS 3. adding image links instead of attachments to the Jira tickets - Dev should download if needed 4. adding image links next to the embedded images in google docs specs - Dev should zoom in to the doc 5. combining classes for react components using arrays:

const btnClassName = [
bla ? 'blablalba' : null,
'toggle-btn',
on ? 'toggle-btn-on' : 'toggle-btn-off',
].filter(Boolean).join(' ')
<button className={btnClassName} />
  1. dynamic html tags using jsx const Subtitle =h${this.props.inSideBar ? 7 : 5};<Subtitle>{POWr.simpleCopies('components.reviews.it_will_help_us')}</Subtitle>

Praneeta Mhatre:

  1. minimum availability requirement after a deploy - Dev responsibility to be available for 2 hours, or find someone who you can hand off the responsibility.

  2. async load react and other heavy libs if you are editing one of the non-react heavy pages (only example of react heavy pages I know - standalone and settings) 

  require.ensure([], require => {       const React = require('react');
      const ReactDOM = require('react-dom');

  1. how to find 2 reviewers - https://docs.google.com/spreadsheets/d/1GqPc-no3dEycnh5q7eOva7IlUbuUyGZpM2kHcjgfQSE/edit#gid=0 , would ideally be 1 sr. engineer and 1 not yet sr. engineer - to be added to Quass
  2. add js- to classes that are used for js eg js-import-existing-appshttps://gitlab.com/powr/powr/merge_requests/2792/diffs
  3. #statusofallthings before merging to master

Puru Dahal WTF is rails model as_json, and how/why to avoid it? - Puru will create a ticket for this

Ben Ross staging takes 20 min to deploy now? - 2 tickets - bring back asset caching during deploy and create shared sass files for common css

Praneeta Mhatre https://www.loom.com/share/f2cffddadf5249b2b12bdeca748a72fa Desktop Recording June 6th, 2019 usually it lets me add a password but this one was created as a guest user booooo

 Follow-ups: none.

Fires: none.

 Show and tell: none.

how do we feel this week collisions Sharing test servers wario rooms public channels qa testing all things nice