Skip to main content

Weekly Engineering April 2019

Before: ttps://www.getoutline.com/doc/weekly-eng-q1-2019-wcYwcKn60Mhttps://www.getoutline.com/doc/weekly-engineering-mar-2019-j3sLv5deiF

Apr 25: - no fires, but SF weather kept us warm​

Agenda:

Praneeta Mhatre:

  1. hardcoding free - vs free - staging - we have an ability to classify app types (will follow up later)real_app_type = Rails.env == 'production' ? app_detail.try(:app_type) : app_detail.try(:alias)```return shopify_free_apps.include?(real_app_type)
1. conditionally hide vs conditionally show
1. process for handling task. - ideally engineers do not work on a task that does not have a ticket. create a bare n

**Liza Poliachenko**:
1. Can we get a BrowserStack.com share account
1. why its important to give testers a jira card,  and why tasks without cards will not be tested


**Follow ups**:
* Ben will put notes for best practices - fires
* APP has crashed - ROLLBACK without preboot.
* Ben/Liza - are we doing better with getting AB instructions?
* Joe - tabs/2 spaces fixed?
* Sergey - react upgrade status?


**Firesfromlastweek:**

**Show and tell**:
Puru: file upload

**how do we feel this week**
1. collisions
1. Sharing test servers
1. wario rooms
1. public channels
1. qa testing 
1. all things nice


## Apr 11: - meeting :fire: week :fire: meeting

**Agenda**:

**Brent Gummow**:
1. importing css files? when do you need to restart server? sometimes importing files does not act as expected
1. window js functions in React - can we or can't we?


**Sergey Tyan**:
make all props required in propTypes and explicitly pass null if the prop is optional https://reactjs.org/docs/typechecking-with-proptypes.html (edited) 
add proptypes when you are working on a 

**Praneeta Mhatre**:
1. css in js

2. pairing + code reviews  + PM approval <3- Reminder, unless this is a hotfix we should not be shipping without :thumbsup::skin-tone-5: - nagging is acceptable in such situations
**Puru Dahal** :
How/who to assign for code review?
[Engineering Badges](https://docs.google.com/spreadsheets/d/1GqPc-no3dEycnh5q7eOva7IlUbuUyGZpM2kHcjgfQSE/edit#gid=0) + Combination of Sr/Md/Er/Jr Ers.
automated test . - 

3. https://www.getoutline.com/doc/handlechangecomplete-jeg6Z8SYCG
4. use react modals instead of bootstrap modals

**Puru Dahal** :
Form response table/app_info and idx and different apps using them in different ways and formats. (documentation) - needs ticket

**Follow ups**:
* na


**Firesfromlastweek:**
1. **unblocked features**
1. **wix form responses**
1. **autoresponder**


**Show and tell**:
**Ben Ross:**
https://www.getoutline.com/doc/how-do-tutorials-work-zdlvoe09Ah

**Yerassyl Diyas**: 
unblocked features demo
slides: https://docs.google.com/presentation/d/1UVu0Uz0ZV4-xuWM0sxo0afp6uFC8MFtkDHsNQsFilyA/edit#slide=id.p

**how do we feel this week**
1. collisions
1. Sharing test servers
1. wario rooms
1. public channels
1. qa testing 
1. all things nice



## Apr 4: - reviews week

**Agenda**:
**Puru Dahal**: 
1. [https://tech.lendinghome.com/zero-downtime-migrations-with-activerecord-and-postgresql-b3aca53ffbe6](https://tech.lendinghome.com/zero-downtime-migrations-with-activerecord-and-postgresql-b3aca53ffbe6)[Zero Downtime Migrations with ActiveRecord and PostgreSQL](https://tech.lendinghome.com/zero-downtime-migrations-with-activerecord-and-postgresql-b3aca53ffbe6?gi=fd66d9e19126)
1. readis wildcard - [https://gitlab.com/powr/powr/merge_requests/2363/diffs](https://gitlab.com/powr/powr/merge_requests/2363/diffs)
1. Sql-ize it! - why and how of the formbuilder dashboard active record query. discuss lessons. - Ivan gets credit.

**Praneeta Mhatre**:
Duplicate simple copies
**Joe Curlee:**
1.Book recommendation: https://www.amazon.com/Clean-Coder-Conduct-Professional-Programmers/dp/0137081073
2. Should we start versioning our site?

**Follow ups**:
Simple copies post deploy issue:  [https://gitlab.com/powr/powr/merge_requests/2235](https://gitlab.com/powr/powr/merge_requests/2235) - done
Puru Brent look into IPs

<3 for MRs from PMs.

**Firesfromlastweek:**

**Show and tell**:

**how do we feel this week**
1. collisions - ha ha ha ha ha - Sergey and Brent share thoughts
1. Sharing test servers
1. wario rooms
1. public channels
1. qa testing 
1. all things nice