Skip to main content

Weekly eng meeting 1212

Puru Dahal: Rails 5.2 credentials

Jen Kintzler: Hey team! For our tasks in prioritized, we are seeing the very large majority just labeled as medium. When most of the tasks are labeled as medium, it does kind of defeat the purpose of having a priority. So if you could just take a second and think about your task as possibly being a 'low' or maybe even a 'high', please do so. Remember, all tasks will be tested as quickly as we can get to them so don't worry if your task is labeled as 'low', we will still get to it šŸ™ƒ Thanks! Valeriy Borodayev: I believe, most of engs took priority from JIRA tickets.

Brent Gummow: host/platform wix stuff

Aigul Imadildayeva: maybe everyone already know)) but for those who don’t: looks like we can avoid using <FRAGMENT> or <div> for wrapping RETURN in react component by just wrapping everything in empty tag Example:

const SayMyName = (props) => {
return (
<>
<h1>Hello my Name is {props.name}</h1>
<h1>Hello my Last Name is {props.lastname}</h1>
</>
)
}

Also learnt new setState (no need this any more)

  const [value, setValue] = React.useState(ā€˜ToDo’);
const onInputChange = (e) => {
setValue(e.target.value)
} (edited)
**Sergey Tyan**: our react version currently doesn’t support useState

Praneeta Mhatre Regarding - Anuarbek Zakiryanov - Get rid of duplicated code from wix files https://gitlab.com/powr/powr/merge_requests/3910 We are not at a point where we can add back the interdependency between wix and powr configs when we introduced the two separate configs, it was a very conscious choice. We have often accidentally broken things in wix while changing things on POWr. We do not have enough automated test coverage to ensure that this does not happen. The separate config file are an exception to the DRY rule because of the intent of ā€œseparation of concernsā€ (edited) In the future if there are more platforms like Wix, we’ll have configs for them too We can revisit this MR’s approach once we have some way of ensuring that we will not break Wix by making a small tweak in POWr config